Skip to content

Conversation

mhucka
Copy link
Contributor

@mhucka mhucka commented Aug 6, 2025

Make all notebook tests use stable cirq after the 1.6.0 release.

Ref: https://github.com/quantumlib/Cirq/blob/main/docs/dev/notebooks.md#lifecycle

Fixes #7556

Update `NOTEBOOKS_DEPENDING_ON_UNRELEASED_FEATURES` to reflect changes
in the contents of the `docs/simulate` directory.
@mhucka mhucka marked this pull request as ready for review August 6, 2025 14:33
@mhucka mhucka requested review from vtomole and a team as code owners August 6, 2025 14:33
@mhucka mhucka requested a review from viathor August 6, 2025 14:33
@github-actions github-actions bot added the Size: XS <10 lines changed label Aug 6, 2025
@mhucka mhucka requested review from pavoljuhas and dstrain115 August 6, 2025 14:43
Copy link

codecov bot commented Aug 6, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.49%. Comparing base (1be4d9a) to head (e3b3344).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7561      +/-   ##
==========================================
- Coverage   97.49%   97.49%   -0.01%     
==========================================
  Files        1101     1101              
  Lines       99421    99421              
==========================================
- Hits        96934    96933       -1     
- Misses       2487     2488       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mhucka mhucka added priority/before-1.6.1 Finish before the Cirq 1.6.1 release area/docs labels Aug 7, 2025
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@github-actions github-actions bot added size: M 50< lines changed <250 and removed Size: XS <10 lines changed labels Aug 12, 2025
@pavoljuhas pavoljuhas changed the title Fix #7556: update isolated_notebook_test.py Test all notebooks vs stable Cirq after the 1.6.0 release Aug 12, 2025
@pavoljuhas pavoljuhas changed the title Test all notebooks vs stable Cirq after the 1.6.0 release Test all notebooks vs stable Cirq after the release Aug 12, 2025
@pavoljuhas
Copy link
Collaborator

The point of https://github.com/quantumlib/Cirq/blob/main/docs/dev/notebooks.md#lifecycle is to make NOTEBOOKS_DEPENDING_ON_UNRELEASED_FEATURES empty and to change any pip-install instructions in the affected notebooks to install stable cirq.

Copy link
Collaborator

@pavoljuhas pavoljuhas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after pushing d432d4b...58a8fd7. Please check if this looks OK on your side.

@mhucka mhucka added this pull request to the merge queue Aug 12, 2025
Merged via the queue into quantumlib:main with commit b5ca970 Aug 12, 2025
35 checks passed
@mhucka mhucka deleted the mh-7556 branch August 12, 2025 02:12
pavoljuhas added a commit that referenced this pull request Aug 14, 2025
Make all notebook tests use stable cirq after the 1.6.0 release.

Ref:
https://github.com/quantumlib/Cirq/blob/main/docs/dev/notebooks.md#lifecycle

Fixes #7556

---------

Co-authored-by: Pavol Juhas <[email protected]>
ddddddanni pushed a commit to ddddddanni/Cirq that referenced this pull request Aug 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/docs priority/before-1.6.1 Finish before the Cirq 1.6.1 release size: M 50< lines changed <250
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test all notebooks vs stable Cirq after the 1.6.0 release
2 participants