-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Test all notebooks vs stable Cirq after the release #7561
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Update `NOTEBOOKS_DEPENDING_ON_UNRELEASED_FEATURES` to reflect changes in the contents of the `docs/simulate` directory.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7561 +/- ##
==========================================
- Coverage 97.49% 97.49% -0.01%
==========================================
Files 1101 1101
Lines 99421 99421
==========================================
- Hits 96934 96933 -1
- Misses 2487 2488 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
The `allowlisted_users` argument is already in the stable cirq.
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
The point of https://github.com/quantumlib/Cirq/blob/main/docs/dev/notebooks.md#lifecycle is to make |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM after pushing d432d4b...58a8fd7. Please check if this looks OK on your side.
Make all notebook tests use stable cirq after the 1.6.0 release. Ref: https://github.com/quantumlib/Cirq/blob/main/docs/dev/notebooks.md#lifecycle Fixes #7556 --------- Co-authored-by: Pavol Juhas <[email protected]>
Make all notebook tests use stable cirq after the 1.6.0 release. Ref: https://github.com/quantumlib/Cirq/blob/main/docs/dev/notebooks.md#lifecycle Fixes quantumlib#7556 --------- Co-authored-by: Pavol Juhas <[email protected]>
Make all notebook tests use stable cirq after the 1.6.0 release.
Ref: https://github.com/quantumlib/Cirq/blob/main/docs/dev/notebooks.md#lifecycle
Fixes #7556